Don't check exports for being valid C/C++ identifiers in side modules #24359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unbreaks Rust side modules, which have been broken since emscripten-core#23563 was merged.
Collaborator
Author
|
@sbc100 I think we discussed a while back the possibility of adding a Rust smoke test. I think such a smoke test would have picked up this regression. Would it be okay if I added such a smoke test? |
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
May 17, 2025
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
May 17, 2025
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
May 17, 2025
Collaborator
|
Sure we have |
Collaborator
Author
|
Closed as fixed by #24427. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unbreaks Rust side modules, which have been broken since #23563 was merged.