Skip to content

Proper EDNS handling and cleaner NOERROR response in DNSSERVER #11411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 9 commits into from
Jun 20, 2025
Merged

Proper EDNS handling and cleaner NOERROR response in DNSSERVER #11411

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
730b9ce
Proper EDNS handling and cleaner NOERROR response
Kolkman May 30, 2025
5323ee2
fix: library.properties
Kolkman May 31, 2025
cfa5ac5
Merge branch 'espressif:master' into DNSServer-EDNS
Kolkman May 31, 2025
557d9c7
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Jun 4, 2025
c400f34
Spelling Corrected and minor clarification in comments
Kolkman Jun 5, 2025
e64e96a
Removing commented out code fragments
Kolkman Jun 5, 2025
645728f
Merge branch 'master' into DNSServer-EDNS
Kolkman Jun 7, 2025
28fc7e4
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Jun 10, 2025
a28c02b
fix(pr): Fix typo
me-no-dev Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing commented out code fragments
  • Loading branch information
@Kolkman
Kolkman committed Jun 5, 2025
commit e64e96ac4e42f3e341247e55bb9f29832efbb537
3 changes: 1 addition & 2 deletions libraries/DNSServer/src/DNSServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ void DNSServer::_handleUDP(AsyncUDPPacket &pkt) {

bool DNSServer::requestIncludesOnlyOneQuestion(DNSHeader &dnsHeader) {
dnsHeader.ARCount = 0; // We assume that if ARCount !=0 there is a EDNS OPT packet, just ignore
return ntohs(dnsHeader.QDCount) == 1 && dnsHeader.ANCount == 0 && dnsHeader.NSCount == 0; // && dnsHeader.ARCount == 0;
return ntohs(dnsHeader.QDCount) == 1 && dnsHeader.ANCount == 0 && dnsHeader.NSCount == 0;
}

String DNSServer::getDomainNameWithoutWwwPrefix(const unsigned char *start, size_t len) {
Expand Down Expand Up @@ -196,7 +196,6 @@ void DNSServer::replyWithCustomCode(AsyncUDPPacket &req, DNSHeader &dnsHeader) {
void DNSServer::replyWithNoAnsw(AsyncUDPPacket &req, DNSHeader &dnsHeader, DNSQuestion &dnsQuestion) {

dnsHeader.QR = DNS_QR_RESPONSE;
// dnsHeader.QDCount = 1;
dnsHeader.ANCount = 0;
dnsHeader.NSCount = htons(1);

Expand Down