Skip to content

Conversation

@ScionOfDesign
Copy link
Contributor

Closed milestones with 0 issues currently display as having 0% completion. This makes sense if the milestone is still open, but if the milestone is closed it seems like that it should show 100% completeness instead.

Before:
image
After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations labels Dec 20, 2025
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CASE WHEN is SQL standard

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2025
@ScionOfDesign
Copy link
Contributor Author

Will investigate the failed db-tests.

@ScionOfDesign
Copy link
Contributor Author

The failures don't seem to be related to my changes. The failure is in Test_MigrateFromGiteaToGitea and is on line 192, which has to do with emojis.
assert.ElementsMatch(t, []string{"laugh"}, reactionTypes) // gitea's author is ghost which will be ignored when migrating reactions

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2025
@lafriks lafriks enabled auto-merge (squash) December 20, 2025 13:34
@lafriks lafriks merged commit 495fee4 into go-gitea:main Dec 20, 2025
38 of 42 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 20, 2025
silverwind added a commit to silverwind/gitea that referenced this pull request Dec 20, 2025
* origin/main:
  Closed milestones with no issues now show as 100% completed (go-gitea#36220)
  Show edit page confirmation dialog on tree view file change (go-gitea#36130)
  Fix regression in writing authorized principals (go-gitea#36213)
  [skip ci] Updated translations via Crowdin
  Convert locale files from ini to json format (go-gitea#35489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants