Resolve Go fmt and vet warnings #4134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some of these fixes are in generated code files, yet I didn't spot any changes to the code generator (idl_gen_go.cpp). Without changes, these fixes will get lost in a future commit. @rw any other comments? |
Contributor
Author
|
Maybe run |
Collaborator
|
We'd prefer to simply generate well-formatted code, so these changes should be applied to the code generator. |
Contributor
Author
|
Of course you do pref that. It's too much work for me tough. Especially the little details like field value aligns such as https://github.com/google/flatbuffers/pull/4134/files#diff-841c858bd318a96a7b116201e772d453 |
Collaborator
|
If you don't want to fix those, simply leave the generated code files out of this PR, and we can still merge the other files. |
Collaborator
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting inconsistencies are annoying with vendorin by other projects.