Don't parse malformed string as boolean #1775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean.parseBoolean(String) returns for any non-"true" string false. This is extremely error-prone because for strings like "yes" the user likely does not expect false. Now the methods which were previously using parseBoolean(...) only accept "true" or "false" (case insensitive) and throw exceptions for any other value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
Java's
Boolean.parseBoolean(String)returns for any non-"true" stringfalse.This is extremely error-prone because for strings like "yes" the user likely does not expect
false.This pull request changes the methods which were previously using
parseBoolean(...)to now only accept "true" or "false" (case insensitive) and to throw exceptions for any other value.