Update README.md #2142
Update README.md #2142
Conversation
Change the Gradle dependency in README.md to be more consistent with Guava
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| ```gradle | ||
| dependencies { | ||
| implementation 'com.google.code.gson:gson:2.9.0' | ||
| implementation("com.google.code.gson:gson:2.9.0") |
There was a problem hiding this comment.
My impression is that single quotes are preferred in Gradle scripts. So possibly it would make more sense to propose the opposite change for the Guava documentation.
There was a problem hiding this comment.
implementation("...") is probably what you see more commonly for the Kotlin build script DSL, but apparently it is also valid for the Groovy DSL, see google/guava#3673 which proposed that for Guava.
See also the Gradle documentation for an example and click the "Groovy" and "Kotlin" tabs of the code block.
There was a problem hiding this comment.
Thanks for the background! In that case, I think this change makes sense. But, we can't accept it until the CLA has been signed.
|
Hmm |
Change the Gradle dependency in README.md to be more consistent with Guava