Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Fix missing templating variables #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbengo
Copy link

@sbengo sbengo commented Sep 3, 2020

When uploading a dashboard with templating generated from zero with
grafonet-lib Grafana fills missing template fields and asks the user to
save the dashboard due to changes produced

This PR adds those missing fields and allows the user to upload a
Dashboard without being asked to save it

Note that definition field is set up to not configurable, as I couldn't find its use

Fixes #263

@sbengo sbengo force-pushed the fix/miss_templ_fields branch from f6d0864 to 79a37aa Compare September 3, 2020 16:05
When uploading a dashboard with templating generated from zero with
grafonet-lib Grafana fills missing template fields and asks the user to
save the dashboard due to changes produced

This PR adds those missing variables

Fixes grafana#263
@sbengo sbengo force-pushed the fix/miss_templ_fields branch from 79a37aa to 7773dc1 Compare September 3, 2020 16:31
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard are requested to be saved due to missing fields on template
2 participants