fix(prost-build): Map wrapper types to primitives #2471
+49
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This commit address the issue raised in #2388, where well-known types such as
google.protobuf.BoolValuewould appear assuper::boolrather than the correct primitives.The issue was reproduced here, and produces the following output when
cargo buildis run (only the first occurrence is shown):Solution
We address this by adding new cases to the existing enum for the various wrapper types contained in
google/protobuf/wrappers.proto, when not compiling well-known types as proto structs directly. This is broadly in line with the patch suggested in the issue by @zhaohaiyun9, but is a little less broad and adds test coverage.