ci: rust checkfmt

[ethanyzhang]

Done checklist

• docs/SPEC.md updated
• Test cases written

[affo]

This looks great, thank you!

If you prefer, we can skip formatting those generated files: rust-lang/rustfmt#2522

Basically you can add a rustfmt.toml file with:

ignore = [
    "src/ast/flatbuffers/ast_generated.rs",
    "src/ast/flatbuffers/semantic_generated.rs",
]

For more, see: https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#ignore

I don't request for changes because your solution seems good enough.

[jpacik]

Just to echo what @affo said, I would prefer to ignore generated files, but approving anyway.

[ethanyzhang]

I tried the ignore option, got this:

Warning: can't set `ignore = IgnoreList { path_set: {"src/ast/flatbuffers/ast_generated.rs", "src/ast/flatbuffers/semantic_generated.rs"}, rustfmt_toml_path: "" }`, unstable features are only available in nightly channel.
Warning: can't set `ignore = IgnoreList { path_set: {"src/ast/flatbuffers/semantic_generated.rs", "src/ast/flatbuffers/ast_generated.rs"}, rustfmt_toml_path: "" }`, unstable features are only available in nightly channel.
Warning: can't set `ignore = IgnoreList { path_set: {"src/ast/flatbuffers/semantic_generated.rs", "src/ast/flatbuffers/ast_generated.rs"}, rustfmt_toml_path: "" }`, unstable features are only available in nightly channel.

Rebased the PR against master

[codecov-io]

Codecov Report

Merging #2189 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2189   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files         287      287           
  Lines       39006    39006           
=======================================
  Hits        20705    20705           
  Misses      16281    16281           
  Partials     2020     2020

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30748c2...219e295. Read the comment docs.

[ethanyzhang]

In this case, I feel formatting the generated code is OK. Unless you have some strong reasons not to @jlapacik @affo .

[affo]

@yzhang1991 Oh, only available in nightly.

Go ahead then 👍

Thank you!