feat(dependencies/mqtt): add a dependency for mqtt #4169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66d02f2 to
f7d7421
Compare
This adds a dependency for mqtt and enforces usage of the ip validator when using mqtt. It also updates publish to respect the timeout instead of potentially waiting indefinitely.
f7d7421 to
734a56a
Compare
scbrickley
approved these changes
Oct 25, 2021
Contributor
scbrickley
left a comment
There was a problem hiding this comment.
This all looks good to me. Thanks for doing this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dependency for mqtt and enforces usage of the ip validator
when using mqtt. It also updates publish to respect the timeout instead
of potentially waiting indefinitely.
Fixes #4144.
Done checklist