[TORCH] Add Kullback-Leibler divergence loss support #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Can someone review this please? @vivekkhandelwal1 @penguin-wwy @AmosLewis @rsuderman |
fb50c06 to
7fb518d
Compare
7edde2e to
84f5325
Compare
Signed-off-by: Zahid Wakeel <[email protected]>
Signed-off-by: Zahid Wakeel <[email protected]>
84f5325 to
daf7aee
Compare
Contributor
Author
|
Reminder: This PR is ready to be reviewed @vivekkhandelwal1 & @zjgarvey |
zjgarvey
approved these changes
Jun 20, 2025
Collaborator
zjgarvey
left a comment
There was a problem hiding this comment.
Looks good to me. Let me know if you need a merge.
projects/pt1/python/torch_mlir_e2e_test/test_suite/kl_div_loss.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Zahid Wakeel <[email protected]>
Contributor
Author
@zjgarvey It's ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of #4203.
mean, sum, batchmean, none)reduction: batchmeanrequires special handling by calling op withsumand then dividing it by inputbatch_size.Some tests are failing and are marked either in expected failures or crashing set.
torch.aten.xlogy.Tensor' | TORCHDYNAMO_CRASHING_SETValue: tensor(1)
Declaration: aten::div.Scalar(Tensor self, Scalar other) -> Tensor
Cast error details: Cannot cast tensor(1) to number | ONNX_XFAIL_SET
torch.aten.size.int' that was explicitly marked illegal | ONNX_TOSA_XFAIL_SET