Skip to content

Conversation

@tossnet
Copy link
Contributor

@tossnet tossnet commented Oct 18, 2023

Pull Request

📖 Description

Once I'd started using this component, I simply copied and pasted this first sample. My existing code that uses Stream and of course it didn't work straight away. But after some research I realized that the InputFileMode property is SaveToTemporaryFolder, by default and this attribute is not added. I think the documentation would be clearer if this parameter were specified in this samples

🎫 Issues

👩‍💻 Reviewer Notes

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

Once I'd started using this component, I simply copied and pasted this first sample.
My existing code that uses Stream and of course it didn't work straight away.
But after some research I realized that the InputFileMode property is SaveToTemporaryFolder, by default and this attribute is not added.
I think the documentation would be clearer if this parameter were specified in this samples
@tossnet
Copy link
Contributor Author

tossnet commented Oct 18, 2023

@microsoft-github-policy-service agree

@vnbaaij vnbaaij merged commit 861cb3a into microsoft:dev Oct 18, 2023
vnbaaij added a commit that referenced this pull request Oct 23, 2023
* fix: chinese abbreviated day name in FluentCalendar (#834)
* Minor documentation corrections (#837)
* Fix #836
* fix NavMenuLink width
* Rename solution file
* FluentMenu: move overlay into anchored section code
* Update version on index page
* Update Menu example
* Add some (😉) more tests
* [Unit Tests] Add Unit Tests in .razor files (#844)
* Fix gitignore
* Add FluentBadgeTests.razor
* Fix #845 Exception with NavMenuLink
* Fix #841 (#842)
* Hide collapse button on demo site menu and remove some commented code
* Fix #851
* Fix #852
* Update Fluent UI System Icons to 1.1.220 (#854)
* Small ToC script optimization
* Use latest SDKs
* Make demos better when opening in light/dark mode
* Fix initial theme switch setting
* Fix: Add '@' to keyframe for fade-out animation (#855)
* MessageBar: fix fadein effect
* [Accessibility] Fix some FluentButton and FluentNav aria attributes (#853)
* Fix FluentButton aria-label based on Title
* Fix NavMenu aria
* Fix Button Titles
* Fix unit Tests
* Add examples and documentation for the Persona component. (#843)
* Fix the Persona samples to use "@DataSource.SamplePicture" instead of using external resources.
* [Autocomplete] Update some Accessibility issues (#866)
* Update Autocomplete Accessibility items
* Fix Enter key when popup is closed
* Update Previous and Next titles (and Unit Tests)
* [FluentGrid] Add FluentGridItem with no breakpoints (#862)
* Add FluentGridItem with no breakpoints
* Update FluentValidationSummary.razor
* Fix #865
* docs: Update sample InputFileDefault.razor (#867)
* Update InputFileDefault.razor
* Update InputFileByCode.razor
* Update the documentation: inverse Api and Example sections
* fix: Implement DesignToken.WithDefault and use in Demo site (#869)
* Add 'System' option to theme settings
* Fix aria-orientation (#877)
* Fix #861 and also fix rendering in case of manual grid (#874)
* Fix security scanning workflow
* Add @ref to some layout components and adjust css of those to use css vars for font properties
* Update WhatsNew
* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants