[onnxruntime_perf_test] Fix custom_allocator_ destruction order. #24136
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
approved these changes
Mar 25, 2025
quic-zhaoxul
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Apr 17, 2025
…rosoft#24136) Move the allocator data member declaration before the `Ort::Value` container data members that might use the allocator so that the `Ort::Value` containers will be destroyed first. `custom_allocator_` may be used as the allocator for the `Ort::Value`s in `test_inputs_` and `outputs_`. The allocator shouldn't be destroyed before `Ort::Value`s allocated with it are freed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
custom_allocator_destruction order.Move the allocator data member declaration before the
Ort::Valuecontainer data members that might use the allocator so that theOrt::Valuecontainers will be destroyed first.custom_allocator_may be used as the allocator for theOrt::Values intest_inputs_andoutputs_. The allocator shouldn't be destroyed beforeOrt::Values allocated with it are freed.Motivation and Context
Fix segfault on Android.