Skip to content

[webgpu-ep] Fix test_batchnorm_example #24184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

[webgpu-ep] Fix test_batchnorm_example #24184

merged 2 commits into from
Mar 27, 2025
+9 −7

Conversation

jchen10
Copy link
Contributor

@jchen10 jchen10 commented Mar 26, 2025

This fixes the missing component handling for the input and output variables in BatchNorm operator.

@jchen10
[webgpu-ep] Fix test_batchnorm_example
Loading
Loading status checks…
c60bf44 
This fixes the missing component handling for the input and output
variables in BatchNorm operator.
@jchen10
Copy link
Contributor Author

jchen10 commented Mar 26, 2025

The corresponding code lines in js-ep operator.

@jchen10
Copy link
Contributor Author

jchen10 commented Mar 26, 2025

@fs-eire @guschmue PTAL

@fs-eire
Copy link
Contributor

fs-eire commented Mar 26, 2025

I think the shader cache is missing too:

onnxruntime/js/web/lib/wasm/jsep/webgpu/ops/batch-norm.ts

Line 125 in 4d5e274

hint: `${attributes.epsilon}_${attributes.format}_${spatial}_${components}`,

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Mar 26, 2025
guschmue
guschmue previously approved these changes Mar 26, 2025
View reviewed changes
@jchen10
Fix CacheHint
Loading
Loading status checks…
3e2bcbf
@jchen10
Copy link
Contributor Author

jchen10 commented Mar 27, 2025

I think the shader cache is missing too:

onnxruntime/js/web/lib/wasm/jsep/webgpu/ops/batch-norm.ts

Line 125 in 4d5e274

hint: `${attributes.epsilon}_${attributes.format}_${spatial}_${components}`,

Good catch, done!

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@fs-eire fs-eire merged commit 86b4c78 into microsoft:main Mar 27, 2025
84 of 86 checks passed
@jchen10 jchen10 deleted the batchnorm branch April 2, 2025 13:59
quic-zhaoxul pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Apr 17, 2025
@jchen10
[webgpu-ep] Fix test_batchnorm_example (microsoft#24184)
e6e3c52 
This fixes the missing component handling for the input and output
variables in BatchNorm operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire

@guschmue guschmue

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jchen10 @fs-eire @guschmue