Skip to content

upgrade dawn version to 4cb1f9be152a4fa6bb695c08cd707ab078a1e2fb #24247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Mar 30, 2025

Description

Bump version of Dawn to 4cb1f9be152a4fa6bb695c08cd707ab078a1e2fb.

Changes to the patches to Dawn:

Removed patches because they are already merged into upstream or resolved in a different way:

  • (public) CMake fix to support Emscripten v4.0.3+
  • (private) Fix external ref count for "external" device in emwgpu C++ implementation
  • (private) Allow "external" buffer in emwgpu C++ implementation

Keep unchanged patches:

  • (private) Remove hard-coded CMAKE_OSX_DEPLOYMENT_TARGET in Dawn's CMake files

Rewritten patches:

  • (public) Fix emwgpu C++ implementation for buffer destroy

Corresponding changes in ORT

  • Dawn API changes
    • follow changes to wgpu::Limits
  • remove the usage of DAWN_EMSCRIPTEN_TOOLCHAIN
  • use wgpu::InstanceDescriptor in wgpu::Instance creation in WASM since it is supported now.

@fs-eire fs-eire added the ep:WebGPU ort-web webgpu provider label Mar 30, 2025
@fs-eire fs-eire merged commit 30115cf into main Mar 31, 2025
95 of 97 checks passed
@fs-eire fs-eire deleted the fs-eire/upgrade-dawn branch March 31, 2025 19:24
quic-zhaoxul pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Apr 17, 2025
…rosoft#24247)

### Description

Bump version of Dawn to 4cb1f9be152a4fa6bb695c08cd707ab078a1e2fb.

### Changes to the patches to Dawn:

Removed patches because they are already merged into upstream or
resolved in a different way:
- (public) CMake fix to support Emscripten v4.0.3+
- (private) Fix external ref count for "external" device in emwgpu C++
implementation
- (private) Allow "external" buffer in emwgpu C++ implementation

Keep unchanged patches:
- (private) Remove hard-coded CMAKE_OSX_DEPLOYMENT_TARGET in Dawn's
CMake files

Rewritten patches:
- (public) Fix emwgpu C++ implementation for buffer destroy

### Corresponding changes in ORT

- Dawn API changes
  - follow changes to `wgpu::Limits`
- remove the usage of `DAWN_EMSCRIPTEN_TOOLCHAIN`
- use `wgpu::InstanceDescriptor` in `wgpu::Instance` creation in WASM
since it is supported now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants