Skip to content

[CoreML] Add support for int64 #24462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2025
Merged

[CoreML] Add support for int64 #24462

merged 7 commits into from
Apr 30, 2025

Conversation

carzh
Copy link
Contributor

@carzh carzh commented Apr 17, 2025

Description

Add int64 as a supported datatype for moving nodes to the CoreML EP.

We already convert constants automatically from int64 to int32 for CoreML by calling narrow.

Adding the conversion for outputs as well.

Motivation and Context

  • More nodes supported on CoreML

Note on the Unsqueeze op

According to #22975 there is a bug with the Unsqueeze op with scalar inputs on x86.

I was running into a bug for unsqueezes that unsqueezed a scalar input to a tensor of shape [1] since CoreML doesn't support scalar values for MLProgram. I adapted the HandleX86ArchUnsqueeze method but alternatively, can replace with an identity operator or add some additional checks. I went with adapting the HandleX86ArchUnsqueeze method since it seemed like the fastest solution.

carzh added 2 commits April 17, 2025 15:38
@carzh carzh requested review from skottmckay and edgchen1 April 17, 2025 22:44
… suggestions for comments
@carzh carzh merged commit a470da1 into main Apr 30, 2025
91 of 98 checks passed
@carzh carzh deleted the carzh/coreml-int64 branch April 30, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants