Skip to content

Allow EpContext models with input/output models completely in buffers #24463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Apr 18, 2025

Description

Re-enables (and fixes) generation of compiled EpContext models with both input and output models stored in buffers.

Motivation and Context

Previous PR #24176 inadvertently added a check that disabled storing both input and output models in buffers. However, we need this functionality. This was actually a fortunate scenario, as it led to the discovery of a bug.

Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adrianlizarraga adrianlizarraga merged commit cd9c02f into main Apr 18, 2025
87 of 89 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/compile-api-allow-all-models-in-buffers branch April 18, 2025 17:03
ashrit-ms pushed a commit that referenced this pull request Apr 24, 2025
…#24463)

### Description
Re-enables (and fixes) generation of compiled EpContext models with
**both** input and output models stored in buffers.

### Motivation and Context
Previous PR #24176 inadvertently added a check that disabled storing
both input and output models in buffers. However, we need this
functionality. This was actually a fortunate scenario, as it led to the
discovery of a bug.
intbf pushed a commit to intbf/onnxruntime that referenced this pull request Apr 25, 2025
…microsoft#24463)

### Description
Re-enables (and fixes) generation of compiled EpContext models with
**both** input and output models stored in buffers.

### Motivation and Context
Previous PR microsoft#24176 inadvertently added a check that disabled storing
both input and output models in buffers. However, we need this
functionality. This was actually a fortunate scenario, as it led to the
discovery of a bug.

Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants