-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Rename matmul_4bits_quantizer.py to matmul_nbits_quantizer.py #24472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
onnxruntime/python/tools/quantization/matmul_nbits_quantizer.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/quantization/matmul_nbits_quantizer.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/llama/convert_to_onnx.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/transformers/models/phi2/convert_to_onnx.py
Outdated
Show resolved
Hide resolved
459307e
to
538309d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename matmul_4bits_quantizer.py to matmul_quantizer.py? Previously we have 4 bits only, so we add 4bits in between. It seems a matmul_quantizer to me
nbits naming follows MatMulNBits op. |
## Describe your changes onnxruntime uses MatMulNBitsQuantizer since 1.22.0, due to microsoft/onnxruntime#24472 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
## Describe your changes onnxruntime uses MatMulNBitsQuantizer since 1.22.0, due to microsoft/onnxruntime#24472 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
### Description * Rename filename and class name since it supports 4 and 8 bits. * Update HQQWeightOnlyQuantizer to support 8 bits. * Update some comments. ### Motivation and Context #24384 added 8 bits support for the default weight only quantizer.
…oft#24472) ### Description * Rename filename and class name since it supports 4 and 8 bits. * Update HQQWeightOnlyQuantizer to support 8 bits. * Update some comments. ### Motivation and Context microsoft#24384 added 8 bits support for the default weight only quantizer. Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
Description
Motivation and Context
#24384 added 8 bits support for the default weight only quantizer.