-
Notifications
You must be signed in to change notification settings - Fork 41
SQL-2947: Remove eap logic #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jchemburkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bucaojit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to allow direct cluster to work look good 👍
In the .evg.yml file there are still a lot of references to the eap build. Are we planning on removing that in a future change and making these changes now to get the driver release out?
I suggest we should at the very least take out the logic in line 1004 for export variables.
if [[ "${triggered_by_git_tag}" == *"-libv"* ]]; then
echo "Detected EAP tag format."
export BUILD_TYPE="eap"
# tag should be formatted as 'v<JDBC major>.<minor>.<patch>-libv<libmongosqltranslate major>.<minor>.<patch>'
export MDBJDBC_VER=$(echo ${triggered_by_git_tag} | awk -F'-libv' '{print $1}' | sed s/v// )
export LIBMONGOSQLTRANSLATE_VER=$(echo ${triggered_by_git_tag} | awk -F'-libv' '{print $2}')
else
And where we set the property for -PisEapBuild=true in build jdbc driver.
| - func: "publish compliance report" | ||
|
|
||
| - name: ssdlc-artifacts-snapshot-standard | ||
| - name: ssdlc-artifacts-snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have guessed that this would have failed the build since the name here is changed but not in lines 68,69. I can't leave a comment on those lines as they're not updated.
- name: ssdlc-artifacts-snapshot-standard
- name: ssdlc-artifacts-snapshot-eap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, good catch! It just didn't run it, but it didn't fail, and there is no warning ...
No description provided.