Skip to content

Conversation

@nbagnard
Copy link
Collaborator

No description provided.

@nbagnard nbagnard requested a review from a team as a code owner September 11, 2025 15:20
Copy link
Collaborator

@jchemburkar jchemburkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bucaojit bucaojit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to allow direct cluster to work look good 👍

In the .evg.yml file there are still a lot of references to the eap build. Are we planning on removing that in a future change and making these changes now to get the driver release out?

I suggest we should at the very least take out the logic in line 1004 for export variables.

            if [[ "${triggered_by_git_tag}" == *"-libv"* ]]; then
              echo "Detected EAP tag format."
              export BUILD_TYPE="eap"
              # tag should be formatted as 'v<JDBC major>.<minor>.<patch>-libv<libmongosqltranslate major>.<minor>.<patch>'
              export MDBJDBC_VER=$(echo ${triggered_by_git_tag} | awk -F'-libv' '{print $1}' | sed s/v// )
              export LIBMONGOSQLTRANSLATE_VER=$(echo ${triggered_by_git_tag} | awk -F'-libv' '{print $2}')
            else

And where we set the property for -PisEapBuild=true in build jdbc driver.

- func: "publish compliance report"

- name: ssdlc-artifacts-snapshot-standard
- name: ssdlc-artifacts-snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have guessed that this would have failed the build since the name here is changed but not in lines 68,69. I can't leave a comment on those lines as they're not updated.

      - name: ssdlc-artifacts-snapshot-standard
      - name: ssdlc-artifacts-snapshot-eap

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good catch! It just didn't run it, but it didn't fail, and there is no warning ...

@nbagnard nbagnard added this pull request to the merge queue Sep 12, 2025
Merged via the queue into mongodb:master with commit 2e5278c Sep 12, 2025
7 checks passed
@nbagnard nbagnard deleted the SQL-2947_RemoveEAPLogic branch September 12, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants