Properly glob keys as separate arguments to read_multi #13
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, read_multi was passing all keys as a single array, which works with DalliStore, but only due to a discrepancy in the behavior of DalliStore compared to the default (ActiveSupport::Cache::Store).
dblock
added a commit
that referenced
this pull request
May 6, 2013
Properly glob keys as separate arguments to read_multi
|
I released 1.5.1, fyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, read_multi was passing all keys as a single array, which works with
DalliStore, but only due to a discrepancy in the behavior ofDalliStorecompared to the default (ActiveSupport::Cache::Store). This discrepancy has been addressed by petergoldstein/dalli#362.The upshot of this bug is that
Mongoid::CachedJsonwould never actually utilize the cache with a cache other thanDalliStore, and a call trace that hitread_multi. In particular, this degrades performance in most:testand:developmentenvironments, and introduces a discrepancy between:testand:production.