-
Notifications
You must be signed in to change notification settings - Fork 12
Ruby 3 compatibility #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to first put back CI (Travis is MIA) and add Ruby 3.x to the mix. Want to help? Maybe copy from https://github.com/mongoid/mongoid-grid_fs or https://github.com/mongoid/mongoid-locker? |
babd257
to
264d852
Compare
264d852
to
bceebcf
Compare
93b07c3
to
6e80f43
Compare
@dblock Thanks for the quick feedback! Have addressed this in the last commits. CI running green here https://github.com/leamotta/mongoid-scroll/actions |
Looks great! Care to update https://github.com/mongoid/mongoid-scroll/blob/master/CHANGELOG.md please? Danger would complain but it will only run after we merge on future PRs. |
@dblock Ready! |
@leamotta Any interest in helping out with maintaining this library? If yes email me your rubygems login to dblock at dblock dot org. |
Ruby 3 introduces breaking changes when it comes to positional and keyword arguments https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
This PR adjusts the call to I18n#translate, using the splat operator (**) to send a set of keyword arguments instead of a hash.

Prevents the following error: