-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[ADD] Recruitment: Source analysis reporting #10634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Felicious - this is ready for a first round review! |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job with this reporting doc, @larm-odoo !
Your doc kept things short on the essentials content and jump straight to the use case! It was a great one, and it was really easy to follow your instructions to generate that report. Was this your first reporting doc? It was flawless!! 🥳
I just had a few suggestions for rewording and to possibly rename a section. I also had some suggestions at the bottom for a follow-up PR if you choose to take me up on it 😊
Incredible work with this 🥇
d90853e to
d674dfa
Compare
|
Than you so much for your feedback, @Felicious! I really liked your suggestions on how to improve this doc- thank you so much! |
|
@ksc-odoo - this is ready for a final review! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @larm-odoo -- just finished my Final Review. Once you address my feedback, and implement the necessary changes, feel free to move this to Tech Review. Thanks! 👍
d674dfa to
211d33e
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo! Nice work on this new reporting doc for Recruitment.
I think you covered a solid initial use-case of analyzing sources for applicants. I have a small handful of suggestions for you to consider, approving now.
Thank you for your work!
.....
@robodoo delegate=larm-odoo
| .. image:: source_analysis/source-analysis.png | ||
| :align: center | ||
| :alt: The default bar chart of the source analysis information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this image retaken with more zoom, since the text is currently illegible 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to retake this image with more zoom please :)
211d33e to
6374cd2
Compare
|
@robodoo r+ |

No documentation for recruitment reporting exists, Creating the first doc for Source Analysis.
Project Task Card for this PR.