Skip to content

Conversation

@larm-odoo
Copy link
Contributor

No documentation for recruitment reporting exists, Creating the first doc for Source Analysis.

Project Task Card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Aug 7, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team August 7, 2024 16:16
@larm-odoo larm-odoo requested a review from a team August 7, 2024 16:17
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a first round review!

@larm-odoo larm-odoo added the 5 label Aug 7, 2024
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job with this reporting doc, @larm-odoo !

Your doc kept things short on the essentials content and jump straight to the use case! It was a great one, and it was really easy to follow your instructions to generate that report. Was this your first reporting doc? It was flawless!! 🥳

I just had a few suggestions for rewording and to possibly rename a section. I also had some suggestions at the bottom for a follow-up PR if you choose to take me up on it 😊

Incredible work with this 🥇

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-source-analysis-report branch from d90853e to d674dfa Compare August 12, 2024 14:05
@larm-odoo
Copy link
Contributor Author

Than you so much for your feedback, @Felicious! I really liked your suggestions on how to improve this doc- thank you so much!

@larm-odoo larm-odoo requested a review from a team August 12, 2024 14:06
@larm-odoo
Copy link
Contributor Author

@ksc-odoo - this is ready for a final review!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo -- just finished my Final Review. Once you address my feedback, and implement the necessary changes, feel free to move this to Tech Review. Thanks! 👍

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-source-analysis-report branch from d674dfa to 211d33e Compare August 13, 2024 18:51
@larm-odoo larm-odoo requested a review from a team August 13, 2024 18:51
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo! Nice work on this new reporting doc for Recruitment.

I think you covered a solid initial use-case of analyzing sources for applicants. I have a small handful of suggestions for you to consider, approving now.

Thank you for your work!
.....
@robodoo delegate=larm-odoo

Comment on lines +25 to +27
.. image:: source_analysis/source-analysis.png
:align: center
:alt: The default bar chart of the source analysis information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this image retaken with more zoom, since the text is currently illegible 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to retake this image with more zoom please :)

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-source-analysis-report branch from 211d33e to 6374cd2 Compare August 13, 2024 22:03
@larm-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants