Skip to content

Conversation

@larm-odoo
Copy link
Contributor

Adding the Team Performance reporting doc as it does not yet exist.

Original task card for this PR

@robodoo
Copy link
Collaborator

robodoo commented Sep 9, 2024

Pull request status dashboard

@larm-odoo larm-odoo marked this pull request as draft September 9, 2024 20:09
@larm-odoo larm-odoo force-pushed the 17.0-recruitment-new-team-performance-report-larm branch from a48d04f to aa5896c Compare September 11, 2024 17:15
@larm-odoo larm-odoo marked this pull request as ready for review September 11, 2024 17:15
@larm-odoo larm-odoo requested a review from a team September 11, 2024 17:16
@C3POdoo C3POdoo requested a review from a team September 11, 2024 17:18
@larm-odoo larm-odoo requested review from a team and removed request for a team September 11, 2024 17:18
@larm-odoo
Copy link
Contributor Author

Hi @pabr-odoo - this is ready for a peer review!

@larm-odoo larm-odoo added the 5 label Sep 12, 2024
Copy link

@pabr-odoo pabr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @larm-odoo great job on this doc! The uses cases are an excellent addition. I left a handful of suggestions, so feel free to move this on to final review once you've given it a look.

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-new-team-performance-report-larm branch from aa5896c to 76eeef0 Compare September 12, 2024 21:36
@larm-odoo larm-odoo requested a review from a team September 12, 2024 21:36
@larm-odoo
Copy link
Contributor Author

Hi @ksc-odoo , this is ready for a final review!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo -- just finished my Final Review. Nice work on this PR! Only have a small handful of comments that require your attention. Once you take care of the necessary adjustments, feel free to tag this for Tech Review. Thanks! 👍

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-new-team-performance-report-larm branch from 76eeef0 to a51c28c Compare September 13, 2024 19:12
@larm-odoo larm-odoo requested a review from a team September 13, 2024 19:12
@larm-odoo
Copy link
Contributor Author

Hi @samueljlieber - this is ready for a tech review =)

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, nice work on this new reporting doc for Recruitment!

I am requesting a few changes, please tag me for one more quick look after the following is addressed :)

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-new-team-performance-report-larm branch from a51c28c to c5e5918 Compare September 13, 2024 20:08
@larm-odoo
Copy link
Contributor Author

OMG I didn't compress the pics after you showed me yesterday! Everything should be fixed now- I swear I saw the green checkmark though- doh! Ready for another look @samueljlieber.

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @larm-odoo, thank you!
.....
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants