Skip to content

Conversation

@larm-odoo
Copy link
Contributor

No reporting doc exists for Referrals- it was a short section in the main Referrals doc. Now this is a stand-alone with a specific use case.

Original task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Sep 11, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team September 11, 2024 21:48
@larm-odoo larm-odoo requested a review from a team September 11, 2024 21:48
@larm-odoo
Copy link
Contributor Author

Hi @ksc-odoo - this is ready for a peer review!

@larm-odoo larm-odoo added the 5 label Sep 12, 2024
@larm-odoo larm-odoo force-pushed the 17.0-referrals-adding-new-reporting-doc-larm branch from dc73c22 to 012fd38 Compare September 12, 2024 14:59
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo -- just finished my Peer Review of this PR. Nicely done. Only have a small handful of suggestions that require your attention. Once you address those, and implement the necessary suggestions, feel free to move this to Final Review. Thanks! 👍

@larm-odoo larm-odoo force-pushed the 17.0-referrals-adding-new-reporting-doc-larm branch from 012fd38 to a949105 Compare September 12, 2024 17:40
@larm-odoo larm-odoo requested a review from a team September 12, 2024 17:40
@larm-odoo
Copy link
Contributor Author

Hi @StraubCreative - this is ready for a final review!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @larm-odoo, I like the use case you added here!
On to @samueljlieber for TR/merge 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, thanks for your work on this brand new Referrals reporting doc. I have a couple suggestion for you to consider, approving!
.....
@robodoo delegate=larm-odoo

@larm-odoo larm-odoo force-pushed the 17.0-referrals-adding-new-reporting-doc-larm branch from a949105 to 5db31cf Compare September 13, 2024 21:19
@larm-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 13, 2024
closes #10993

Signed-off-by: Lara Martini (larm) <[email protected]>
@robodoo
Copy link
Collaborator

robodoo commented Sep 13, 2024

@larm-odoo staging failed: ci/runbot on 78154bbff8eacf5cf15eebe2f9164024a37ca78a (view more at https://runbot.odoo.com/runbot/build/68206680)

@StraubCreative
Copy link
Contributor

@robodoo retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants