Skip to content

[IMP] accounting: bank rec massive update for 18.3 UI #13604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] accounting: bank rec massive update for 18.3 UI #13604

wants to merge 1 commit into from
+510 −250

Conversation

dade-odoo
Copy link
Contributor

@dade-odoo dade-odoo commented Jun 3, 2025 •
edited
Loading

task-4771607

@robodoo
Copy link
Collaborator

robodoo commented Jun 3, 2025

Pull request status dashboard

@dade-odoo dade-odoo marked this pull request as draft June 3, 2025 09:36
@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch from 1e615ac to e99cad0 Compare July 23, 2025 12:29
@dade-odoo dade-odoo marked this pull request as ready for review July 23, 2025 12:37
@C3POdoo C3POdoo requested review from a team July 23, 2025 12:40
@dade-odoo dade-odoo removed request for a team July 23, 2025 12:45
@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch from e99cad0 to 7bafc0f Compare July 23, 2025 12:49
@dade-odoo dade-odoo changed the title [IMP] bank rec: massive update for 18.3 UI [IMP] accounting: bank rec massive update for 18.3 UI Jul 23, 2025
@dade-odoo dade-odoo requested a review from a team July 24, 2025 06:16
malb-odoo
malb-odoo reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on runbot, few comments otherwise this looks amazing already thanksss

@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch 2 times, most recently from 0da02d4 to 8882007 Compare July 25, 2025 07:40
@auva-odoo auva-odoo requested review from auva-odoo and removed request for a team July 29, 2025 06:38
auva-odoo
auva-odoo requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work on this @dade-odoo! 🙌 🧠 In addition to my review comments:

  • Do you think we should also mention these options?
image
  • I noticed both "Click" and "Click on" are used; it might be worth choosing one for consistency.

Let me know if you'd like to discuss anything!

@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch from 8882007 to 7cd557e Compare August 1, 2025 12:13
@dade-odoo dade-odoo requested a review from auva-odoo August 1, 2025 12:13
@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch 2 times, most recently from 773b910 to 8a6b86a Compare August 1, 2025 14:00
@dade-odoo
Copy link
Contributor Author

Thanks for the review @auva-odoo :) I went with "click" instead of "click on", and I plan to add the "Find Missing Transactions" section to the bank sync doc in a future PR. I did add a "Find Duplicate Transactions" section to the transactions doc, so let me know what you think of that.
Thanks again!

auva-odoo
auva-odoo requested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @dade-odoo, I know it wasn't easy but you really did a great job 🙂 We're almost there; I just have a few questions; the rest are just minor comments 😉

@dade-odoo
[IMP] bank rec: massive update for 18.3 UI
Loading
Loading status checks…
0b9fca3 
This PR includes updates for multiple pages:
- Reconciliation
- Reconciliation Models
- Transactions
- Internal Transfers

task-4771607

This commit updates the bank reconciliation page and other related
pages to align with the 18.3 changes.
@dade-odoo dade-odoo force-pushed the saas-18.3-reconciliation-dade branch from 8a6b86a to 0b9fca3 Compare August 5, 2025 08:01
@dade-odoo dade-odoo requested a review from auva-odoo August 6, 2025 13:47
auva-odoo
auva-odoo approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dade-odoo ! LGTM 🎉

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 7, 2025
@dade-odoo
[IMP] bank rec: massive update for 18.3 UI
Loading
Loading status checks…
86048fb 
This PR includes updates for multiple pages:
- Reconciliation
- Reconciliation Models
- Transactions
- Internal Transfers

task-4771607

This commit updates the bank reconciliation page and other related
pages to align with the 18.3 changes.

closes #13604

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@fw-bot fw-bot mentioned this pull request Aug 7, 2025
Closed
@robodoo robodoo closed this Aug 7, 2025
@fw-bot fw-bot mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malb-odoo malb-odoo

@auva-odoo auva-odoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dade-odoo @robodoo @malb-odoo @auva-odoo