[IMP] Localizations/Malaysia: improve doc #13639
Conversation
|
|
afma-odoo
left a comment
There was a problem hiding this comment.
Hi @XIDO-odoo! Thanks a lot for reviewing the page :)
I added a few comments and suggestions. Just let me know if you have any questions. Thank you!
| .. note:: | ||
| The :guilabel:`Debit Notes module` must be installed to issue a debit note. |
There was a problem hiding this comment.
For technical reasons, I can't do it, but I think the module information should be added to the "Modules installation" section, and a reference to that section should be added to make it complete.
| .. note:: | |
| The :guilabel:`Debit Notes module` must be installed to issue a debit note. | |
| .. note:: | |
| The :ref:`Debit Notes module <malaysia/configuration/modules>` must be installed to issue a debit note. |
There was a problem hiding this comment.
I revised it according to your suggestion; but I'm not sure if I should if this should be added to the "Modules installation" section, because this is not a "localization" module of Malaysia.
Could you please check if this is suitable? Thank you!
There was a problem hiding this comment.
Yes, you're right. I was going to ask my colleague what we should do in this case, but I tested it on a runbot first. The module is installed by default, so I don't think the note is necessary. What do you think?
content/applications/finance/fiscal_localizations/malaysia/myinvois-add-intermediary.png
Show resolved
Hide resolved
70d06b2 to
ca905ea
Compare
|
Hello @afma-odoo , thank you for the suggestion and comments; sorry for the late follow up. Thank you! |
ca905ea to
39f48e0
Compare
afma-odoo
left a comment
There was a problem hiding this comment.
Thank you @XIDO-odoo for the updates. I just have some minor suggestions.
Please let me know if you have any questions ;)
Thanks
| .. note:: | ||
| The :guilabel:`Debit Notes module` must be installed to issue a debit note. |
There was a problem hiding this comment.
Yes, you're right. I was going to ask my colleague what we should do in this case, but I tested it on a runbot first. The module is installed by default, so I don't think the note is necessary. What do you think?
39f48e0 to
283ed26
Compare
|
Hello @afma-odoo , Thank you for the follow up! I have revised it based on your suggestion. If you have any other comments or feedback, please just let me know. Thank you! |
afma-odoo
left a comment
There was a problem hiding this comment.
Thank you @XIDO-odoo for the update!
I approve the review and ping be-doc-review for the final review :)
auva-odoo
left a comment
There was a problem hiding this comment.
Hey @XIDO-odoo thank you for your work on this! I added a few minor comments in my review. Also:
- I see there's a conflict on this PR, could you please resolve it?
- I know you didn't change that part but I noticed the Malaysia - E-invoicing Extended Features module (l10n_my_edi_extended) is missing from the list; should we add it?
Thanks again! And thank you @afma-odoo for the thorough review 🙏
|
Hello @auva-odoo , thank you for the feedback. I have revised it based on your suggestions; but for the first point "conflict on this PR", could you please help check if it has been resolved. If there are any other points necessary to be revised, please just let me know. Thank you! cc: @afma-odoo |
ff9d1c1 to
7513ea2
Compare
7513ea2 to
c768c8c
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Hey @XIDO-odoo I squashed your 2 commits, fixed the conflict in the process, and fixed an issue with an anchor. Could you please check everything looks good on your side? If it is, you can r+ the PR :) Thank you for your work again!
@robodoo delegate+
|
Hello @auva-odoo , thank you for your help! This is good on my side. Please allow me to r+ it. @robodoo r+ |
closes #13639 Signed-off-by: Ximo Dong (xido) <[email protected]>
Following the improvements made in Malaysia e-invoicing module, the following task is to update the improved features and additional flows involved.