Skip to content

[FW][FIX] l10n_din5008: fix text overflow in company details footer #208236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 1, 2025

Steps to reproduce:

  1. Setting > Navigate to Configure Document layout > layout : DIN 5008.
  2. Accounting > invoice > PDF without Payment.

Note :Ensure the address has at least 33 characters without spaces to trigger the issue.

Issue:
The footer of the invoice is not displaying correctly — the company name in the
bottom left corner is overlapping and not aligned properly.

Cause:
An upstream PR modified the footer text sizing, leading to layout issues when
fields contain long values.

Solution:
Removed the text-nowrap class from the company details in the footer section.
Improved section alignment using colspan and made minor adjustments to footer text sizing.
These changes prevent content overlap in the company information section of reports,
ensuring proper display regardless of content length.

opw: 4731515

Before changes applied:
image
After changes applied:
image

Forward-Port-Of: #206774

Steps to reproduce:

1. Setting > Navigate to Configure Document layout > layout : DIN 5008.
2. Accounting > invoice > PDF without Payment.
 Note :Ensure the address has at least 33 characters without spaces to trigger
 the issue.

Issue:
 The footer of the invoice is not displaying correctly — the company name in the
 bottom left corner is overlapping and not aligned properly.

Cause:
 An upstream PR modified the footer text sizing, leading to layout issues when
 fields contain long values.

Solution:
Removed the `text-nowrap` class from the company details in the footer section.
Improved section alignment using `colspan` and made minor adjustments to footer
text sizing.
These changes prevent content overlap in the company information section of
reports, ensuring proper display regardless of content length.

Opw: 4731515
X-original-commit: 9b3fcd6
@robodoo
Copy link
Contributor

robodoo commented May 1, 2025

Pull request status dashboard

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 1, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented May 1, 2025

This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 1, 2025
robodoo pushed a commit that referenced this pull request May 2, 2025
Steps to reproduce:

1. Setting > Navigate to Configure Document layout > layout : DIN 5008.
2. Accounting > invoice > PDF without Payment.
 Note :Ensure the address has at least 33 characters without spaces to trigger
 the issue.

Issue:
 The footer of the invoice is not displaying correctly — the company name in the
 bottom left corner is overlapping and not aligned properly.

Cause:
 An upstream PR modified the footer text sizing, leading to layout issues when
 fields contain long values.

Solution:
Removed the `text-nowrap` class from the company details in the footer section.
Improved section alignment using `colspan` and made minor adjustments to footer
text sizing.
These changes prevent content overlap in the company information section of
reports, ensuring proper display regardless of content length.

closes #208236

Opw: 4731515
X-original-commit: 9b3fcd6
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Khushi Srivastava (khsr) <khsr@odoo.com>
@robodoo robodoo closed this May 2, 2025
@fw-bot fw-bot deleted the saas-17.4-18.0-opw-4731515-footer-data-layout-issue-khsr-430708-fw branch May 9, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants