Skip to content

[dev/Wasm] Removing unsupported try catch #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: v3/dev/wasm-experimental
Choose a base branch
from
Draft

[dev/Wasm] Removing unsupported try catch #2783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
369002d
Create SECURITY.md
martinhsv Aug 4, 2022
1eb136c
Merge branch 'SpiderLabs:v3/master' into v3/dev/wasm-fix-stoi-conversion
M4tteoP Aug 9, 2022
1ae46fe
stoi to from_chars, reducing unsupported try catch
M4tteoP Aug 10, 2022
cec93e4
replaces fuzzy_hash std::stoi
M4tteoP Aug 16, 2022
6651741
trying from_chars for double (stod)
M4tteoP Aug 16, 2022
b02f740
trying stringstream for double (stod)
M4tteoP Aug 16, 2022
e2dd00f
tweaking stod to stringstream - seclang-parser
M4tteoP Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trying stringstream for double (stod)
  • Loading branch information
@M4tteoP
M4tteoP committed Aug 17, 2022
commit b02f7407b40cb4beabf360b1cc34827f16d04fe6
6 changes: 0 additions & 6 deletions .vscode/settings.json
View file
Open in desktop

This file was deleted.

13 changes: 7 additions & 6 deletions src/actions/rule_id.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#include <iostream>
#include <string>
#include <charconv>
#include <sstream>

#include "modsecurity/transaction.h"
#include "modsecurity/rule.h"
Expand All @@ -28,11 +28,12 @@ namespace actions {

bool RuleId::init(std::string *error) {
std::string a = m_parser_payload;

const auto format = std::chars_format::fixed;
const auto conv_res = std::from_chars(a.data(), a.data() + a.size(), m_ruleId, format);
if (conv_res.ec == std::errc::invalid_argument || conv_res.ec == std::errc::result_out_of_range) {
// Conversion error

std::stringstream ss;
ss<<a;
ss>>m_ruleId;
if (ss.fail()) {
ss.clear();
m_ruleId = 0;
error->assign("The input \"" + a + "\" does not " \
"seems to be a valid rule id.");
Expand Down