Tags: oxia-db/oxia
Tags
fixes: wrong package import (#832) ### Motivation ``` {"level":"info","time":"2025-12-03T15:29:28.037894751Z","component":"cluster-config-resource","time":"2025-12-03T15:29:28.037907293Z","message":"No cluster config changes detected"} panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xbcce60] goroutine 1 [running]: github.com/pingcap/errors.IsNotFound({0x0?, 0x0?}) /go/pkg/mod/github.com/pingcap/[email protected]/juju_adaptor.go:112 +0x20 github.com/oxia-db/oxia/oxiad/coordinator/metadata.(*clientImpl[...]).Upsert(0x2a0d360?, {0xffffdd37833b, 0x1d1fe1c?}, {0xffffdd37835a?, 0x10}, 0x4000358120) /src/oxia/oxiad/coordinator/metadata/k8s_client.go:109 +0x118 github.com/oxia-db/oxia/oxiad/coordinator/metadata.(*metadataProviderConfigMap).Store(0x4000183720, 0x4000414a80, {0x2612cb6, 0x2}) /src/oxia/oxiad/coordinator/metadata/metadata_configmap.go:143 +0x224 github.com/oxia-db/oxia/oxiad/coordinator/resource.(*status).Update.func1() /src/oxia/oxiad/coordinator/resource/status_resource.go:125 +0x34 github.com/cenkalti/backoff/v4.RetryNotifyWithTimer.Operation.withEmptyData.func1() /go/pkg/mod/github.com/cenkalti/backoff/[email protected]/retry.go:18 +0x24 github.com/cenkalti/backoff/v4.doRetryNotify[...](0x400040afc8?, {0x29e2440, 0x4000506120}, 0x400040b028, {0x0, 0x0?}) /go/pkg/mod/github.com/cenkalti/backoff/[email protected]/retry.go:88 +0xcc github.com/cenkalti/backoff/v4.RetryNotifyWithTimer(0x0?, {0x29e2440?, 0x4000506120?}, 0x0?, {0x0?, 0x0?}) /go/pkg/mod/github.com/cenkalti/backoff/[email protected]/retry.go:61 +0x58 github.com/cenkalti/backoff/v4.RetryNotify(...) /go/pkg/mod/github.com/cenkalti/backoff/[email protected]/retry.go:49 github.com/oxia-db/oxia/oxiad/coordinator/resource.(*status).Update(0x40003f66e0, 0x4000414a80) /src/oxia/oxiad/coordinator/resource/status_resource.go:124 +0xb0 github.com/oxia-db/oxia/oxiad/coordinator.NewCoordinator({0x2a01620, 0x4000183720}, 0x4000121740, 0x4000172540, {0x2a0d958, 0x40004a32e0}) /src/oxia/oxiad/coordinator/coordinator.go:485 +0x6ec github.com/oxia-db/oxia/oxiad/coordinator.NewGrpcServer({{0x40002cd8f0, 0xc}, {0x40002cd910, 0xc}, {0x0, 0x0}, 0x0, 0x0, {0x40002cd900, 0xc}, ...}) /src/oxia/oxiad/coordinator/server.go:106 +0x360 github.com/oxia-db/oxia/cmd/coordinator.exec.func3() /src/oxia/cmd/coordinator/cmd.go:200 +0xcc github.com/oxia-db/oxia/common/process.RunProcess(0x27690a0) /src/oxia/common/process/run.go:27 +0x38 github.com/oxia-db/oxia/cmd/coordinator.exec(0x40004b0500?, {0x2613662?, 0x4?, 0x2613666?}) /src/oxia/cmd/coordinator/cmd.go:188 +0x284 github.com/spf13/cobra.(*Command).execute(0x3fba120, {0x40000a68a0, 0x6, 0x6}) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1015 +0x7d4 github.com/spf13/cobra.(*Command).ExecuteC(0x3fb9880) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1148 +0x350 github.com/spf13/cobra.(*Command).Execute(...) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1071 main.main.func1() /src/oxia/cmd/main.go:96 +0x70 github.com/oxia-db/oxia/common/process.DoWithLabels.func1({0x2a01048?, 0x400021de60?}) /src/oxia/common/process/pprof.go:46 +0x24 runtime/pprof.Do({0x2a01010?, 0x40a0420?}, {{0x40004627e0?, 0x4822b4?, 0x80?}}, 0x4000061db8) /usr/local/go/src/runtime/pprof/runtime.go:51 +0x78 github.com/oxia-db/oxia/common/process.DoWithLabels({0x2a01010, 0x40a0420}, 0x2613612?, 0x2768f20) /src/oxia/common/process/pprof.go:42 +0x204 main.main() /src/oxia/cmd/main.go:86 +0xc8 ```
Added script to tag the releases (#827) Signed-off-by: Matteo Merli <[email protected]>
Added script to tag the releases (#827) Signed-off-by: Matteo Merli <[email protected]>
feat: introduce committed version IDs to avoid accidentally writing d… …irty version ID trackers (#740) ### Motivation introduce committed version IDs to avoid accidentally writing dirty version ID trackers ### Modification - Introduce the committed version ID to avoid increasing the version if the whole write logic failed. - Add another condition on TestDBVersionIDWithError to reproduce the issue.
Fix WriteStream regression: don't send an error client close (#707) ## Summary commit 9310100 Author: mauricebarnum <[email protected]> Date: Tue Jun 10 19:33:06 2025 -0700 public_rpc_server_test: test handling of a client closing a WriteStream After a client sends a write request, receives a response, and closes the write end of the stream, reading from the stream should yield an EOF commit 4a56ff8 Author: mauricebarnum <[email protected]> Date: Tue Jun 10 19:37:13 2025 -0700 Fix WriteStream regression: don't send an error client close The refactoring in c90c791 makes a change that sends an unknown error message to the client when it encounters either a read EOF or an internal context is closed. This can confuse a client that doesn't expect to see any more messages after closing the request side of the stream. This change suppresses the message upon EOF. ## Test output ``` 20:00:12 > git rebase --autosquash --update-refs -x 'go test ./server -run TestWriteClientClose' upstream/main Executing: go test ./server -run TestWriteClientClose Jun 10 20:00:33.369445 INF Starting Oxia standalone config={"AuthOptions":{"ProviderName":"","ProviderParams":""},"DataDir":"/var/folders/c_/ffflkqfj25d590trtpmzss0w0000gn/T/TestWriteClientClose554734378/001/db","DbBlockCacheMB":0,"InternalServerTLS":null,"InternalServiceAddr":"localhost:0","MetricsServiceAddr":"","NotificationsEnabled":true,"NotificationsRetentionTime":0,"NumShards":1,"PeerTLS":null,"PublicServiceAddr":"localhost:0","ServerTLS":null,"WalDir":"/var/folders/c_/ffflkqfj25d590trtpmzss0w0000gn/T/TestWriteClientClose554734378/001/wal","WalRetentionTime":0,"WalSyncData":false} Jun 10 20:00:33.500406 INF Created leader controller component=leader-controller namespace=default shard=0 term=-1 Jun 10 20:00:33.511769 INF Leader successfully initialized in new term component=leader-controller last-entry={"offset":"-1","term":"-1"} namespace=default shard=0 term=0 Jun 10 20:00:33.512651 INF Applying all pending entries to database commit-offset=-1 component=leader-controller head-offset=-1 namespace=default shard=0 term=0 Jun 10 20:00:33.513782 INF All sessions component=session-manager count=0 namespace=default shard=0 term=0 Jun 10 20:00:33.514752 INF Started leading the shard component=leader-controller head-offset=-1 namespace=default shard=0 term=0 Jun 10 20:00:33.525032 INF Started Grpc server bindAddress=127.0.0.1:52943 grpc-server=public Jun 10 20:00:33.533394 INF Update shares assignments. component=shard-assignment-dispatcher current={"namespaces":{"default":{"assignments":[{"int32HashRange":{"maxHashInclusive":4294967295,"minHashInclusive":0},"leader":"","shard":"0"}],"shardKeyRouter":"XXHASH3"}}} previous={"namespaces":{}} Jun 10 20:00:43.967716 WRN Failed to perform write operation error={"error":"EOF","kind":"*errors.errorString","stack":null} component=public-rpc-server Jun 10 20:00:43.974064 INF Closing leader controller component=leader-controller namespace=default shard=0 term=0 Jun 10 20:00:44.011775 INF Stopped Grpc server bindAddress=127.0.0.1:52943 grpc-server=public --- FAIL: TestWriteClientClose (10.66s) public_rpc_server_test.go:70: resp <nil> err rpc error: code = Unknown desc = EOF public_rpc_server_test.go:72: Error Trace: /Users/pixi/src/streamnative/oxia/no-push-eof/server/public_rpc_server_test.go:72 Error: Target error should be in err chain: expected: "EOF" in chain: "rpc error: code = Unknown desc = EOF" Test: TestWriteClientClose FAIL FAIL github.com/streamnative/oxia/server 11.029s FAIL warning: execution failed: go test ./server -run TestWriteClientClose You can fix the problem, and then run git rebase --continue ~/src/streamnative/oxia/no-push-eof on HEAD (581a485) (REBASING 2/4) 20:00:44 > git rebase --continue Executing: go test ./server -run TestWriteClientClose ok github.com/streamnative/oxia/server (cached) Successfully rebased and updated refs/heads/no-push-eof. ```
PreviousNext