fix: Resolve incorrect shape clipping for domain-referenced shapes on n*10th subplot #7576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7463, closes #6362
Resolves issue where shapes referenced to the
domain
of an axis id containing a zero (e.g.ref: 'x10 domain'
) were not clipped to the boundaries of the subplot, as they should have been.Also adds an image mock for this issue to prevent regression.
Thanks to @Ike-lag and @DataScienceIsCool for reporting, and to @Ike-lag for identifying the faulty regex in the codebase!
Before:

After:

Steps for testing
zz_shapes_clipping_double_digit_subplots
mock in the devtools dashboard (after runningnpm run build
and make sure the shapes in the lower-left subplot do not extend beyond the subplot boundariesmaster
, check outmaster
, copy over thezz_shapes_clipping_double_digit_subplots.json
file into the mocks dir, runnpm run build
and then check the mock in the devtools dashboard.