Skip to content

Allow shared_yaxes to work with secondary axes #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 1, 2025
+149 −111
Merged

Allow shared_yaxes to work with secondary axes #5180

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd64e00
Fix sharing of secondary y-axis
May 12, 2025
8f0ac47
Add test
May 12, 2025
948bc38
black
May 12, 2025
dcc607c
black
May 12, 2025
7fd2702
Merge branch 'main' into secondary-y-shared
gvwilson Jun 26, 2025
99e7e3f
feedback
gmjw Jul 19, 2025
42aea20
linewidth
gmjw Jul 19, 2025
a83c6b4
ruff
gmjw Jul 19, 2025
db0feea
Merge branch 'main' into secondary-y-shared
gmjw Jul 19, 2025
610b7ee
Merge branch 'main' into secondary-y-shared
emilykl Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
black
  • Loading branch information
Gareth Williams committed May 12, 2025
commit dcc607c1b34f4aebfbfbe23d37eefa363ebd12c6
8 changes: 6 additions & 2 deletions plotly/_subplots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,9 @@ def _check_hv_spacing(dimsize, spacing, name, dimvarname, dimname):
_configure_shared_axes(layout, grid_ref, specs, "x", shared_xaxes, row_dir, False)
_configure_shared_axes(layout, grid_ref, specs, "y", shared_yaxes, row_dir, False)
if secondary_y:
_configure_shared_axes(layout, grid_ref, specs, "y", shared_yaxes, row_dir, True)
_configure_shared_axes(
layout, grid_ref, specs, "y", shared_yaxes, row_dir, True
)

# Build inset reference
# ---------------------
Expand Down Expand Up @@ -889,7 +891,9 @@ def _check_hv_spacing(dimsize, spacing, name, dimvarname, dimname):
return figure


def _configure_shared_axes(layout, grid_ref, specs, x_or_y, shared, row_dir, secondary_y):
def _configure_shared_axes(
layout, grid_ref, specs, x_or_y, shared, row_dir, secondary_y
):
rows = len(grid_ref)
cols = len(grid_ref[0])

Expand Down