Skip to content

Fix issue when converting matplotlib lines+markers legend to plotly #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issue when converting matplotlib lines+markers legend to plotly #5232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a42707
Fix issue when converting matplotlib lines+markers legend to plotly
robertoffmoura Jun 15, 2025
da37239
Run ruff format
robertoffmoura Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run ruff format
  • Loading branch information
@robertoffmoura
robertoffmoura committed Aug 12, 2025
commit da3723940a96dc8928b97fc4e0327a7ec45fdccc
4 changes: 2 additions & 2 deletions plotly/matplotlylib/renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def draw_bar(self, coll):
) # TODO ditto
if len(bar["x"]) > 1:
self.msg += " Heck yeah, I drew that bar chart\n"
(self.plotly_fig.add_trace(bar),)
self.plotly_fig.add_trace(bar)
if bar_gap is not None:
self.plotly_fig["layout"]["bargap"] = bar_gap
else:
Expand Down Expand Up @@ -503,7 +503,7 @@ def draw_marked_line(self, **props):
marked_line["x"] = mpltools.mpl_dates_to_datestrings(
marked_line["x"], formatter
)
(self.plotly_fig.add_trace(marked_line),)
self.plotly_fig.add_trace(marked_line)
self.msg += " Heck yeah, I drew that line\n"
elif props["coordinates"] == "axes":
# dealing with legend graphical elements
Expand Down
1 change: 1 addition & 0 deletions plotly/matplotlylib/tests/test_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from . import plt


def test_lines_markers_legend_plot():
x = [0, 1]
y = [0, 1]
Expand Down