Rework line ending handling #6
Closed
+48
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the 4 months late reply. go-difflib was one of the first things I wrote in Go, it is not idiomatic and the API should really be reworked. But I do not want to break the API at this point, I know people use it and it is not worth the pain. Maybe someone can fork it and come up with a much better version. |
|
No worries, I'm using a local fork with this patch applied which is good enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello & thank for a nice lib!
I needed to repurpose it a little hence the pull request.
These changes will break current usage, because it changes how lines are stored
It was changed to render line endings with diff.Eol so it could display properly on Windows,
and now simply returns a []string with the diff, without line endings encoded.
The second commit is just some tweaks that gometalinter mentioned.