-
Notifications
You must be signed in to change notification settings - Fork 102
Added shared memory support usage description #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shared memory support usage description #303
Conversation
4b644dc to
68042be
Compare
68042be to
7896f15
Compare
bded37d to
b6fbcbc
Compare
|
I corrected some minor inaccuracies and also added a description how to use the iceoryx introspection to verify whether shared memory is actually used. The introspection works for this purpose but is not build by default, it will likely be updated in the future. It is still useful to get a deeper look into system performance and therefore I added it here. I think this will be very useful to have in the Galactic release and even if there is always room for improvement we should merge the document to master and to galactic soon after. I had colleagues trying it and they found it useful to get started, so it should be in a decent state. @eboasson @clalancette Let me know what you think how we can proceed here. |
dcd159c to
c970b93
Compare
|
@eboasson @clalancette @ivanpauno Just a quick reminder that we would like to get this into the patch 1 of ROS 2 Galactic as far as I know so we should get this merged to master. Feel free to give feedback and I will fix the issues. We are already in the process of internally verifying that the patch will not break anything. @eboasson checked this on ARM64 and found no issues. @dkroenke, others and myself will do so for other platforms. Since this is just a text document it cannot invalidate the tests @eboasson already did. |
ivanpauno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@dkroenke @ivanpauno I corrected the mentioned issues and we should be good to go. |
Signed-off-by: Matthias Killat <[email protected]>
Signed-off-by: Matthias Killat <[email protected]>
Signed-off-by: Matthias Killat <[email protected]>
Signed-off-by: Matthias Killat <[email protected]>
572e8fe to
0a6c4db
Compare
|
@MatthiasKillat @ivanpauno @clalancette @eboasson As this is the shared memory user guide, it would be cool to get this merged so I do not have to send links to a PR. What is missing to have progress here? |
clalancette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but looks OK to me. I'm going to go ahead and fix that nit, then merge this.
Co-authored-by: Chris Lalancette <[email protected]>
|
@clalancette this seems to have dropped off the radar. I'll merge it now, but I don't know if that alone is enough to include it in the patch release. |
Signed-off-by: Matthias Killat [email protected]
Add a brief description how to enable shared memory support. The purpose is to enable a ROS2 user to activate the Shared Memory feature in her applications when using rmw_cyclonedds.
Unfortunately there is no (simple) example yet in the ROS default examples where Shared Memory is actually used (at least none that I am aware of). However, it is fairly straightforward how the talker and listener example needs to be adapted to demonstrate use of shared memory support (essentially just use a fixed size data type, i.e. not a string). This is briefly sketched as well as a list of current restrictions.
Most of the important restrictions should be covered but some of them might change slightly (e.g. QoS requirements) and the document will need updates in this case.
Closes #304