Skip to content

Set ALPN protocols for rustls backend #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Set ALPN protocols for rustls backend #4312

merged 2 commits into from
Apr 26, 2025

Conversation

djc
Copy link
Contributor

@djc djc commented Apr 25, 2025

Fixes #4311.

cc @ctz

@djc djc requested review from ChrisDenton and rami3l April 25, 2025 14:53
@rami3l
Copy link
Member

rami3l commented Apr 25, 2025

@djc Would we want @muja to test this new branch again?


Update: Hmmm the CI is failing now, interesting...

@muja
Copy link

muja commented Apr 25, 2025

I built & ran this branch, still the same error.

@ctz
Copy link
Contributor

ctz commented Apr 25, 2025

I am pretty confident this is not the root cause of #4305

djc added 2 commits April 25, 2025 17:43

Verified

This commit was signed with the committer’s verified signature.
djc Dirkjan Ochtman

Verified

This commit was signed with the committer’s verified signature.
djc Dirkjan Ochtman
@djc
Copy link
Contributor Author

djc commented Apr 25, 2025

Update: Hmmm the CI is failing now, interesting...

We didn't actually enable http2 for our reqwest dependency. Should be better now.

@rami3l rami3l added this pull request to the merge queue Apr 26, 2025
Merged via the queue into master with commit b79969b Apr 26, 2025
29 checks passed
@rami3l rami3l deleted the set-alpn branch April 26, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustup ought to tell rustls an ALPN
4 participants