Remove signature list failure case in other Verifier #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a Verifier construction failure in the path of obtaining the crypto provider's signature list, obtain the list of signatures directly from the provider instead like on the other platforms. This makes failure case debugging consistent across the different platforms the platform verifier supports and makes debugging failures with this verifier easier too.
ctz
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the debugability of the Linux/BSD
othersVerifierimplementation (ref rust-lang/rustup#4305) by separating the crypto provider's logic from the actualWebPkiServerVerifierthat needs instantiated and wrapped.Instead of having a Verifier construction failure in the path of obtaining the crypto provider's signature list, obtain the list of signatures directly from the provider instead like on the other platforms.
This makes failure case debugging consistent across the different platforms the platform verifier supports and just makes debugging failures with the
othersverifier easier too.cc @djc