Skip to content

Make to_dense work without numba #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flying-sheep opened this issue Mar 31, 2025 · 0 comments · Fixed by #71
Closed

Make to_dense work without numba #69

flying-sheep opened this issue Mar 31, 2025 · 0 comments · Fixed by #71
Assignees
@flying-sheep
Labels
parity Any issue needed for feature parity with anndata/scanpy type: numpy/scipy Array types in CPU memory

Comments

@flying-sheep
Copy link
Member

calling to_dense on a csr/csc matrix will call into numba

instead we could show a performance warning and fall back to .toarray()
@flying-sheep flying-sheep added parity Any issue needed for feature parity with anndata/scanpy type: numpy/scipy Array types in CPU memory labels Mar 31, 2025
@flying-sheep flying-sheep linked a pull request Apr 1, 2025 that will close this issue
Allow and test slow to_dense (without numba) #71
Merged
@flying-sheep flying-sheep mentioned this issue Apr 1, 2025
Merged
@flying-sheep flying-sheep self-assigned this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flying-sheep flying-sheep

Labels
parity Any issue needed for feature parity with anndata/scanpy type: numpy/scipy Array types in CPU memory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow and test slow to_dense (without numba) scverse/fast-array-utils
1 participant
@flying-sheep