Add support for var-args method calls with @PolymorphicSignature causing unmatched method signatures #1333

moebarni · 2025-06-25T17:35:03Z

…eck method (which ignores parameter and return types)

# Conflicts: # sootup.callgraph/src/test/java/sootup/callgraph/CallGraphTestBase.java

codecov · 2025-07-01T08:43:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.56%. Comparing base (18baba8) to head (5a00c10).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #1333      +/-   ##
=============================================
+ Coverage      71.47%   71.56%   +0.08%     
  Complexity        19       19              
=============================================
  Files            443      443              
  Lines          18468    18514      +46     
  Branches        2954     2960       +6     
=============================================
+ Hits           13200    13249      +49     
+ Misses          4156     4154       -2     
+ Partials        1112     1111       -1

Components	Coverage Δ
core	`64.87% <ø> (+0.02%)`	⬆️
java.core	`72.56% <ø> (-0.02%)`	⬇️
java.bytecode.frontend	`79.68% <ø> (ø)`
jimple.frontend	`74.25% <ø> (ø)`
apk.frontend	`73.48% <ø> (ø)`
interceptors	`77.08% <ø> (ø)`
callgraph	`84.84% <100.00%> (+1.32%)`	⬆️
codepropertygraph	`75.12% <ø> (ø)`
analysis.intraprocedural	`66.24% <ø> (ø)`
analysis.interprocedural	`67.66% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…eType); undo wrapper

sootup.callgraph/src/test/java/sootup/callgraph/CallGraphTestBase.java

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

JonasKlauke · 2025-07-28T13:30:04Z

sootup.callgraph/src/main/java/sootup/callgraph/RapidTypeAnalysisAlgorithm.java

+            .flatMap(
+                value -> {
+                  // ClassType as returnType
+                  if (value instanceof AbstractInvokeExpr && value.getType() instanceof ClassType) {
+                    return Stream.of((ClassType) value.getType());
+                    // new-expression
+                  } else if (value instanceof JNewExpr) {
+                    return Stream.of(((JNewExpr) value).getType());
+                  }
+                  return Stream.empty();
+                })


we are only checking for new expressions. Method calls are not considered because first you do not check if they are constructor and second because if you would check for constructors you would consider supertypes as instaniated if the constructor contains a super() call.

Rollback applied. New approach required to treat java.lang.invoke.MethodHandle (with its package-private constructor) as instantiated during RTA analysis.

sootup.callgraph/src/main/java/sootup/callgraph/RapidTypeAnalysisAlgorithm.java

JonasKlauke · 2025-07-28T13:34:17Z

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

+      if (targetMethodSignature.getDeclClassType().equals(polymorphicMethodSigs.getDeclClassType())
+          && targetMethodSignature.getName().equals(polymorphicMethodSigs.getName())) {


two cases are not covered which me might have to investigate.

different parameters,

subclasses of classes that contain these methods

Created tests.

No subclasses of java.lang.invoke.MethodHandle/VarHandle possible, both classes have package-private constructors and all their implementations are package-private.

can you access the annotation outside of the package?

No: 'java.lang.invoke.MethodHandle.PolymorphicSignature' is not public in 'java.lang.invoke.MethodHandle'. Cannot be accessed from outside package

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

...up.callgraph/src/test/resources/callgraph/Polymorphic/source/MethodHandleInvokeExample1.java

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

…ary if; added break

…rs to table

JonasKlauke · 2025-07-31T15:32:32Z

fixes also #78

sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

moebarni added 6 commits June 22, 2025 19:57

added MethodHandle test cases

cde2e34

added preanalysis in AbstractCallGraphAlgorithm constructor; added ch…

732834e

…eck method (which ignores parameter and return types)

updated test cases

fa59d4a

added VarHandle test

4436c41

bad "solution" for RTA

f24ff9a

Merge branch 'develop' into 1266-feature-investigate-varargs-cg

eed2df1

# Conflicts: # sootup.callgraph/src/test/java/sootup/callgraph/CallGraphTestBase.java

moebarni requested a review from JonasKlauke July 1, 2025 08:54

moebarni self-assigned this Jul 1, 2025

moebarni added 5 commits July 7, 2025 18:48

wrapper approach (failed to detect new MethodHandle instance)

ece4faa

extended collectInstantiatedClassesInMethod (only for method/varHandl…

9c20cf2

…eType); undo wrapper

with comments and separated version

9eb4cb8

cleaned

5a95bdf

Merge branch 'develop' into 1266-feature-investigate-varargs-cg

3aeebd4

moebarni commented Jul 11, 2025

View reviewed changes

sootup.callgraph/src/test/java/sootup/callgraph/CallGraphTestBase.java Outdated Show resolved Hide resolved

JonasKlauke requested changes Jul 28, 2025

View reviewed changes

soot-oss deleted a comment from JonasKlauke Jul 29, 2025

moebarni added 8 commits July 29, 2025 14:03

deleted sout, comment, first test

1646566

changed method name; deleted test case for example1; deleted unnecess…

d2a4f11

…ary if; added break

deleted sout; added diffParamTest + superClassTest

1d450b4

Merge branch 'develop' into 1266-feature-investigate-varargs-cg

2348c11

fixed format

07de6b4

changed preanalysis data structure to Table

706fc81

formatting

bc8763d

Merge branch 'develop' into 1266-feature-investigate-varargs-cg

2988813

JonasKlauke changed the title ~~investigate varargs param in cg~~ Add support for var-args method calls with @PolymorphicSignature causing unmatched method signatures Jul 31, 2025

deleted duplicate getDeclClassType-method; add methodName-subtype pai…

19397b2

…rs to table

This was linked to issues Jul 31, 2025

Create Backport for MethodHandle/VarHandle #78

Open

[Feature]: Investigate varargs parameter in the call graph algorithm #1266

Open

moebarni added 3 commits August 1, 2025 13:20

updated methodName-subType pairs

5a00c10

rollback collectInstantiatedClassesInMethod

5261278

fmt

ba19f9b

JonasKlauke requested changes Aug 4, 2025

View reviewed changes

structural changes (getMethodsWithPolymorphicAnnotation)

a8aa9d6

		if (targetMethodSignature.getDeclClassType().equals(polymorphicMethodSigs.getDeclClassType())
		&& targetMethodSignature.getName().equals(polymorphicMethodSigs.getName())) {

Uh oh!

Add support for var-args method calls with @PolymorphicSignature causing unmatched method signatures #1333

Are you sure you want to change the base?

Add support for var-args method calls with @PolymorphicSignature causing unmatched method signatures #1333

Uh oh!

Conversation

moebarni commented Jun 25, 2025

Uh oh!

codecov bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonasKlauke Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

moebarni Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JonasKlauke Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

moebarni Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

moebarni Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

JonasKlauke Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

moebarni Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonasKlauke commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 1, 2025 •

edited

Loading