Use static imports for Assertions.assertThat() consistently #48630
+57
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnny Lim <[email protected]>
snicoll
reviewed
Dec 28, 2025
Member
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR. We are not using the static import in assert implementations (main code). I think we should keep it this way. WDYT?
Contributor
Author
|
@snicoll Thanks for the feedback! I don't have a strong opinion on it. I just thought that it's prefered based on the following changes: 90faddf#diff-e9d603edb2e72b3fc962233b6ae08d6391b61bb776bc86ce2039df7860f05866R233 |
Member
|
Good point, I remember reviewing this and then going with it as the OP is an AssertJ maintainer but I think we may want to reconsider this. I'll flag for team attention to get more feedback. |
|
this could be streamlined with the help of picnic or rewrite: |
Pankraz76
pushed a commit
to Pankraz76/spring-boot
that referenced
this pull request
Dec 29, 2025
Signed-off-by: Vincent Potucek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use static imports for
Assertions.assertThat()consistently where possible.