-
-
Notifications
You must be signed in to change notification settings - Fork 11k
docs: fix wrappers assets (images) #36365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix wrappers assets (images) #36365
Conversation
|
@tomaspozo is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for contributing to Supabase! ❤️ Our team will review your PR. A few tips for a smoother review process:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
charislam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tomaspozo! This is a great idea but string replacement is kind of brittle. I would prefer this to be done with a rehype plugin, similar to how we handle linkTransform.
Is this something you want to take on? I would be happy to review an updated PR, or if you don't have that much time to invest, you could open an issue instead!
|
Hi @charislam! thank you for your review and feedback! Yes, I would like to tackle this and get more familiar with the code base and best practices, I expect to keep contributing to the docs 😃 Will make the fix and update the PR! Thank you! |
|
Hi @charislam, I just pushed some changes based on you feedback. Let me know if this is what is wanted, or if there is any additional change I need to make. Thank you! |
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
This adds a small function that updates the assets urls imported by the wrappers md files to use proper external urls from the wrappers repo (just like we load the md files).
What is the current behavior?
The images are not loading in the supabase/docs/wrappers pages because they are referenced as local resources, but they are actually external resources.
What is the new behavior?
With this fix, now they load properly:
Additional context
None.