Skip to content

Conversation

@tomaspozo
Copy link
Member

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

This adds a small function that updates the assets urls imported by the wrappers md files to use proper external urls from the wrappers repo (just like we load the md files).

What is the current behavior?

The images are not loading in the supabase/docs/wrappers pages because they are referenced as local resources, but they are actually external resources.

image

What is the new behavior?

With this fix, now they load properly:

image

Additional context

None.

@vercel
Copy link

vercel bot commented Jun 12, 2025

@tomaspozo is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

Thanks for contributing to Supabase! ❤️ Our team will review your PR.

A few tips for a smoother review process:

  • If you have a local version of the repo, run pnpm run format to make sure formatting checks pass.
  • Once we've reviewed your PR, please don't trivially merge master (don't click Update branch if there are no merge conflicts to be fixed). This invalidates any pre-merge checks we've run.

@vercel
Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
ui-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:04pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cms ⬜️ Ignored (Inspect) Jun 16, 2025 4:04pm
studio ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 4:04pm

@tomaspozo tomaspozo changed the title docs: fix wrappers assets/images loading docs: fix wrappers assets (images) Jun 12, 2025
Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomaspozo! This is a great idea but string replacement is kind of brittle. I would prefer this to be done with a rehype plugin, similar to how we handle linkTransform.

Is this something you want to take on? I would be happy to review an updated PR, or if you don't have that much time to invest, you could open an issue instead!

@tomaspozo
Copy link
Member Author

Hi @charislam! thank you for your review and feedback! Yes, I would like to tackle this and get more familiar with the code base and best practices, I expect to keep contributing to the docs 😃

Will make the fix and update the PR!

Thank you!

@tomaspozo
Copy link
Member Author

Hi @charislam, I just pushed some changes based on you feedback.

Let me know if this is what is wanted, or if there is any additional change I need to make.

Thank you!

@charislam charislam merged commit f96922b into supabase:master Jun 16, 2025
17 checks passed
@tomaspozo tomaspozo deleted the docs/fix-wrappers-assets-urls branch June 16, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants