Add CMake option to control building of examples #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add WEBUI_BUILD_EXAMPLES option (default: ON) - Improves integration when used as subproject via FetchContent
hassandraga
approved these changes
Oct 5, 2025
Member
|
Thank you @kaniteru for the CMake improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an issue when using
FetchContentto include WebUI in another CMake project.In this case,
CMAKE_SOURCE_DIRdoes not point to the WebUI root directory, which results in errors.Additionally, the example projects are always built, even when they are not needed.
So, I made a few small changes to fix this:
CMAKE_SOURCE_DIRwithCMAKE_CURRENT_SOURCE_DIRWEBUI_BUILD_EXAMPLESoption to control whether example projects are builtThank you.