-
Notifications
You must be signed in to change notification settings - Fork 259
Fix problems with navigation events that aren't generated by GtkWebKit. #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(used lib: libwebkit2gtk-4.1-0 on linux Mint). The WebKit engine to apparently doesn't catch the navigations and does not produce navigation events, when something like "webui_bind(_webui_win, "", webui_event_handler);" is called. Although this should be expected behaviour. By implementing a handler for the GtkWebKit decision signal, this navigation event can still be generated. Signed-off-by: Hans Dijkema <[email protected]>
|
There are some fails that do not seem to be related to the changes of this pull request. |
Updated the navigation handler function name and its description for clarity.
Yes, this is a Windows workflow fails to find TLS, this because GitHub added Windows Server 2025. I will try to fix it. |
|
@hdijkema I noticed that catching events now have two different functions, one is the regular |
I'm curious how you want to do that. Oh I see. You can of course catch this in the regulare webui_bind() with an empty string. Great. good Idea I think. |
I will use your own GTK code to catch event and sends it to |
Fixed in 63fb9fc |
Fix problems with navigation events that aren't generated by GtkWebKit.
(used lib: libwebkit2gtk-4.1-0 on linux Mint).
The WebKit engine to apparently doesn't catch the navigations and does not produce navigation events, when something like "webui_bind(_webui_win, "", webui_event_handler);" is called. Although this should be expected behaviour.
By implementing a handler for the GtkWebKit decision signal, this navigation event can still be generated.