-
-
Notifications
You must be signed in to change notification settings - Fork 22
Make the --suffix argument optional in the release workflow, and add a --platform all option
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the --suffix argument optional in the release workflow, and add a --platform all option
#37
Conversation
|
Tested on my fork, all good: https://github.com/agriyakhetarpal/zig-pypi/actions/runs/17711708847/job/50331241037 I think one improvement we can make here is to deduplicate the platforms to build the wheels for, as we currently require both |
|
Yup that would be great. |
|
Even better! On it. |
|
I've tested on my fork as follows.
Both of these have no suffixes. |
|
Is this better? |
|
The workflow now runs well with default values ( |
--suffix argument optional in the release workflow--suffix argument optional in the release workflow, and add a --platform all option
|
Thanks! |
After #22, wheels failed as the
--suffixargument is always supplied to the wheel generation command when it is optional. This PR fixes it.