Skip to content

Conversation

@agriyakhetarpal
Copy link
Contributor

After #22, wheels failed as the --suffix argument is always supplied to the wheel generation command when it is optional. This PR fixes it.

@agriyakhetarpal
Copy link
Contributor Author

Tested on my fork, all good: https://github.com/agriyakhetarpal/zig-pypi/actions/runs/17711708847/job/50331241037

I think one improvement we can make here is to deduplicate the platforms to build the wheels for, as we currently require both make_wheels.py and the workflow file to be updated, which could easily be missed.

@whitequark
Copy link
Collaborator

Yup that would be great. --platform all?

@agriyakhetarpal
Copy link
Contributor Author

Even better! On it.

@agriyakhetarpal
Copy link
Contributor Author

agriyakhetarpal commented Sep 14, 2025

I've tested on my fork as follows.

  1. with a specific platform (aarch64-macos): https://github.com/agriyakhetarpal/zig-pypi/actions/runs/17711933957
  2. with all platforms: https://github.com/agriyakhetarpal/zig-pypi/actions/runs/17711974638

Both of these have no suffixes.

@agriyakhetarpal
Copy link
Contributor Author

Is this better?

@agriyakhetarpal
Copy link
Contributor Author

The workflow now runs well with default values (all platforms, latest stable release, no suffixes): https://github.com/agriyakhetarpal/zig-pypi/actions/runs/17712015516/job/50331918315.

@agriyakhetarpal agriyakhetarpal changed the title Make the --suffix argument optional in the release workflow Make the --suffix argument optional in the release workflow, and add a --platform all option Sep 14, 2025
@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review September 14, 2025 13:44
@whitequark whitequark merged commit 033ea03 into ziglang:main Sep 14, 2025
@whitequark
Copy link
Collaborator

Thanks!

@agriyakhetarpal agriyakhetarpal deleted the make-`--suffix`-optional branch September 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants