-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(auth, expo): lowercase String?
in swift using .lowercased()
#8507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
String?
in swift using .lowercased()
String?
in swift using .lowercased()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable - is this backwards/forwards compatible with older/newer swift versions? Just curious why this is breaking now but not before.
I suppose if we're requiring Xcode 16.2+ now then if they changed the nullability and it affects everyone on Xcode 16.2+ that's just a bugfix vs a potentially breaking change, so it won't work on Xcode < 16.2 anyway...
I couldn't get the CI to kick off again, so I pulled this locally, squashed the two commits to one |
Looks like this was added in this PR, but its just completely invalid swift code. It looks like the author got confused with JS I was having trouble running an |
String?
in swift using .lowercased()
String?
in swift using .lowercased()
When will this fix be pushed out? |
Yep, it's blocking our builds for iOS currently. |
Please release this |
Until this lands you can use patch-package. It worked for me. |
Any update or expected release date? |
Any updates for this? Thanks! |
I don't understand how this issue was introduced, since few days ago ran the build through EAS as a development build and it worked flawlessly, up until thursday or so. |
waiting for a release 😒 |
please release this. |
working through RNFB issues and PRs right now, will try to kick out a release |
Just want to say thanks everyone for your patience and thanks especially for the community help with the Expo plugins. I know Expo is now the recommended default for react-native but if you think how long react-native-firebase has existed, this is a relatively new situation for us. We have always happily hosted the config plugins for Expo since those became possible, but it hasn't been the case that Expo was the default for react-native until quite recently. And we don't currently use Expo internally (yet) so the community help is vital. I'm planning on improving my Expo skills over this year but either way, together we'll keep things moving forward. Cheers |
I'm here committed to help my team and awesome individuals like you keep moving forward on amazing tools like these. Let's make it happen! |
Description
We currently have some javascript code being added via the new
swift
-based plugin. This simply fixes theswift
code.Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I have yet to run the tests locally, is there an easy way to just run the auth package plugin's tests?
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter