Skip to content

fix(auth, expo): lowercase String? in swift using .lowercased() #8507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
+2 −2
Merged

fix(auth, expo): lowercase String? in swift using .lowercased() #8507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/auth/plugin/__tests__/__snapshots__/iosPlugin_openUrlFix.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -355,7 +355,7 @@ public class AppDelegate: ExpoAppDelegate {
options: [UIApplication.OpenURLOptionsKey: Any] = [:]
) -> Bool {
// @generated begin @react-native-firebase/auth-openURL - expo prebuild (DO NOT MODIFY)
if url.host.toLowerCase() == "firebaseauth" {
if url.host?.lowercased() == "firebaseauth" {
// invocations for Firebase Auth are handled elsewhere and should not be forwarded to Expo Router
return false
}
2 changes: 1 addition & 1 deletion packages/auth/plugin/src/ios/openUrlFix.ts
View file
Original file line number Diff line number Diff line change
@@ -155,7 +155,7 @@ export function modifyObjcAppDelegate(contents: string): string | null {
// NOTE: `mergeContents()` doesn't support newlines for the `anchor` regex, so we have to replace it manually
const skipOpenUrlForFirebaseAuthBlockSwift: string = `\
// @generated begin @react-native-firebase/auth-openURL - expo prebuild (DO NOT MODIFY)
if url.host.toLowerCase() == "firebaseauth" {
if url.host?.lowercased() == "firebaseauth" {
// invocations for Firebase Auth are handled elsewhere and should not be forwarded to Expo Router
return false
}