SQL-2437: Don't rebuild the driver from Smoketest #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchemburkar
approved these changes
Nov 27, 2024
| - func: "export variables" | ||
|
|
||
| post: | ||
| - func: "upload jar file" |
Collaborator
There was a problem hiding this comment.
Just to be clear, this is the critical fix for the ticket, correct? that we aren't overwriting the jar file with a new one used for smoke testing?
Collaborator
Author
There was a problem hiding this comment.
The critical part is that we are not overwriting it, correct. The other post functions are for copying the results of the smoke test. Which can be critical when it's failing, but it's not related to why the release version was off.
As for why it was all funky, the line you have above it part of the problem. Because our S3 task will put the same artifacts at the same path if they are running on the same variant.
./gradlew clean shadowJar && in run smoke test was another piece of the puzzle. It was rebuilding the driver.
bucaojit
pushed a commit
to bucaojit/mongo-jdbc-driver
that referenced
this pull request
Apr 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 7, 2025
* SQL-2397: evergreen updates (#289) * add eap to jar names; disable publishing to maven * fix s3 puts * remove silk * update bucket name * cleanup evg file * cleanup pt2 * remove final bucket ref * feedback * SQL-2380: Download and build jars with translation libraries included (#288) * SQL-2380: Initial evergreen attempt to fetch library files * SQL-2380: Do not use variables * SQL-2380: Fix variables * SQL-2380: Update build task to fetch all libraries * SQL-2380: Special case windows for now * SQL-2380: Remove debug code * SQL-2380: Debug code to check that files are included in jar * SQL-2380: Clean up debug code * SQL-2380: Restore unintended change * SQL-2380: Parse lib version from tag and use that for fetching * SQL-2380: Fix typo * SQL-2380: Properly export new variable * Update .evg.yml Co-authored-by: Natacha Bagnard <[email protected]> * Update .evg.yml Co-authored-by: Patrick Meredith <[email protected]> --------- Co-authored-by: Natacha Bagnard <[email protected]> Co-authored-by: Patrick Meredith <[email protected]> * SQL-2288 : Integration tests and loading library from inside the driver (#290) * Add integration tests * Load library based on JVMplatform/os info --------- Co-authored-by: Oliver Bucaojit <[email protected]> * remove fetch mongosqltranslate windows * Revert "remove fetch mongosqltranslate windows" This reverts commit d3d606c. * SQL-2406: Update fetch libmongosqltranslate windows to reuse generic fetch function in JDBC (#291) * remove fetch mongosqltranslate windows * rename windows folder to be consistent with evergreen * SQL-2427: Add release tasks (#293) * Release artifacts to translators-connectors-releases/eap/mongo-jdbc-driver-eap/ Co-authored-by: Oliver Bucaojit <[email protected]> * SQL-2433: Update logic to extract versions (#295) * Update logic to extract versions * Use correct input Co-authored-by: Oliver Bucaojit <[email protected]> --------- Co-authored-by: Oliver Bucaojit <[email protected]> * SQL-2385: JDBC documentation (#292) * SQL-2385: JDBC documentation * feedback and formatting * SQL-2437: Set release version (#298) * Use property to flag tag triggered releases * Simplify logic * Fix typ * Adding useful build logs * SQL-2387: upload jdbc docs (#296) * SQL-2387: upload jdbc docs * udpate name * SQL-2423: correctly report db version (#300) * SQL-2423: correctly report db version * test length * spotless * rework to be more streamlined * SQL-2423: update logic * spotless * add logging * reset libmongosqltranslate * refactor * add comment * spotless * SQL-2467: ensure proper db is used for queries (#305) * SQL-2461: Add getCursorName (#302) * SQL-2461: Add getCursorName * SQL-2461: Add getCursorName * SQL-2461: Add getCursorName * SQL-2436: Split variables intialization for JDBC (#303) * SQL-2436: Split variables intialization for JDBC * SQL-2436: Move SSDLC variables to first logging command * SQL-2460: Add handling for non-integer indexes (#301) * add handling for non-integer indexes * change null to empty string * add filter to stream to remove non-integer indexes * add boolean valueType to sortableBsonDoc * SQL-2463: update release instructions (#304) * SQL-2463: update release instructions * change pr base * remove files * add quotes * wording change * clarify tags * clarify versioning * clarifications * Update Smoketest logic to get jar previously built and not rebuild it (#308) * SQL-2485: Augment original uri for specific auth mech (#310) * Augment original uri for specific auth mech * remove redundant comments * Throw instead of returning Null when the augment the uri won't work * Don't forget to wrap the exception in a SQLException * Spotless * SQL-2534: Add THIRDPARTY-LICENSE notice (#324) * Add THIRDPARTY-LICENSE notice * Clean-up * SQL-2682: Pull mongosqltranslate library from Gradle script (#335) * SQL-2544: Changes for direct cluster integration tests * SQL-2544: Update dc integration test creds * SQL-2544: Fix smoke test for eap and standard build * SQL-2544: Add conditional logic for eap and non-eap builds * SQL-2544: Fix incorrect eap check in integration test * SQL-2544: Fix smoketest for eap build for manual test with env var * SQL-2544: Address review comments * SQL-2544: Fix mongosql library load test * SQL-2544: spotlessApply * SQL-2544: Update version with eap and snapshot * SQL-2544: Re-add jar renaming * Doc update (#349) * chore: update overview to include new unwind syntax * jdbc * SQL-2822: update mongodb driver to automatically fetch newest version >= 5 and < 6 (#350) --------- Co-authored-by: Jonathan Chemburkar <[email protected]> Co-authored-by: Matthew Chiaravalloti <[email protected]> Co-authored-by: Natacha Bagnard <[email protected]> Co-authored-by: Patrick Meredith <[email protected]> Co-authored-by: Ethan Hardy <[email protected]> Co-authored-by: EthanHardyMongo <[email protected]> Co-authored-by: Nathan Leniz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.