Skip to content

Add dataset_id prefix to tables in Visium HD #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaMarconato opened this issue Feb 6, 2025 · 0 comments
Open

Add dataset_id prefix to tables in Visium HD #273

LucaMarconato opened this issue Feb 6, 2025 · 0 comments

Comments

@LucaMarconato
Copy link
Member

Thanks for the clarification. That makes sense.

One small detail. Should not the elements in Tables be renamed as well? Right now they are not (see above). If I try to concatenate two visium_hd SpatialData objects I get a warning about identical names and they are given unique names which are not ideal because do not follow the original patterns, making it harder to know which ones came from where.

>> sdata1
SpatialData object
├── Images
│     ├── 'HM_hires_image': DataArray[cyx] (3, 5057, 6000)
│     └── 'HM_lowres_image': DataArray[cyx] (3, 506, 600)
├── Shapes
│     ├── 'HM_square_002um': GeoDataFrame shape: (2942291, 1) (2D shapes)
│     ├── 'HM_square_008um': GeoDataFrame shape: (187571, 1) (2D shapes)
│     └── 'HM_square_016um': GeoDataFrame shape: (48206, 1) (2D shapes)
└── Tables
      ├── 'square_002um': AnnData (2942291, 18085)
      ├── 'square_008um': AnnData (187571, 18085)
      └── 'square_016um': AnnData (48206, 18085)
with coordinate systems:
    ▸ 'downscaled_hires', with elements:
        HM_hires_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes)
    ▸ 'downscaled_lowres', with elements:
        HM_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes)
    ▸ 'global', with elements:
        HM_hires_image (Images), HM_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes)
>> sdata2
SpatialData object
├── Images
│     ├── 'RS_hires_image': DataArray[cyx] (3, 6000, 5163)
│     └── 'RS_lowres_image': DataArray[cyx] (3, 600, 517)
├── Shapes
│     ├── 'RS_square_002um': GeoDataFrame shape: (2493008, 1) (2D shapes)
│     ├── 'RS_square_008um': GeoDataFrame shape: (160049, 1) (2D shapes)
│     └── 'RS_square_016um': GeoDataFrame shape: (41439, 1) (2D shapes)
└── Tables
      ├── 'square_002um': AnnData (2493008, 18085)
      ├── 'square_008um': AnnData (160049, 18085)
      └── 'square_016um': AnnData (41439, 18085)
with coordinate systems:
    ▸ 'downscaled_hires', with elements:
        RS_hires_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
    ▸ 'downscaled_lowres', with elements:
        RS_lowres_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
    ▸ 'global', with elements:
        RS_hires_image (Images), RS_lowres_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
>> sd.concatenate([sdata1, sdata2])
<stdin>:1: UserWarning: Duplicate table names found. Tables will be added with integer suffix. Set `concatenate_tables` to `True` if concatenation is wished for instead.
SpatialData object
├── Images
│     ├── 'HM_hires_image': DataArray[cyx] (3, 5057, 6000)
│     ├── 'HM_lowres_image': DataArray[cyx] (3, 506, 600)
│     ├── 'RS_hires_image': DataArray[cyx] (3, 6000, 5163)
│     └── 'RS_lowres_image': DataArray[cyx] (3, 600, 517)
├── Shapes
│     ├── 'HM_square_002um': GeoDataFrame shape: (2942291, 1) (2D shapes)
│     ├── 'HM_square_008um': GeoDataFrame shape: (187571, 1) (2D shapes)
│     ├── 'HM_square_016um': GeoDataFrame shape: (48206, 1) (2D shapes)
│     ├── 'RS_square_002um': GeoDataFrame shape: (2493008, 1) (2D shapes)
│     ├── 'RS_square_008um': GeoDataFrame shape: (160049, 1) (2D shapes)
│     └── 'RS_square_016um': GeoDataFrame shape: (41439, 1) (2D shapes)
└── Tables
      ├── 'square_002um_0': AnnData (2942291, 18085)
      ├── 'square_002um_1': AnnData (2493008, 18085)
      ├── 'square_008um_0': AnnData (187571, 18085)
      ├── 'square_008um_1': AnnData (160049, 18085)
      ├── 'square_016um_0': AnnData (48206, 18085)
      └── 'square_016um_1': AnnData (41439, 18085)
with coordinate systems:
    ▸ 'downscaled_hires', with elements:
        HM_hires_image (Images), RS_hires_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
    ▸ 'downscaled_lowres', with elements:
        HM_lowres_image (Images), RS_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
    ▸ 'global', with elements:
        HM_hires_image (Images), HM_lowres_image (Images), RS_hires_image (Images), RS_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)

Originally posted by @ddiez in #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant